fix: dropdown menu fix for accessability announcement #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved by Alessio, accessibility focal on my team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
Correct accessibility issue with dropdown menu.
Invalid text and warning text were not being announced in screen reader.
Why did you do it?
Found during development by Alessio Mantegna. Fix also provided by Alessio.
How have you tested it?
With screen reader in Safari.
Easiest place to test is with the slots story
http://localhost:6006/?path=/story/component-cvdropdown--slots
There you can toggle the warning and invalid slots and confirm they are announced.
Were docs updated if needed?